Skip to content

Include metadata and partitionOffset into merge reply begin#599

Merged
jfallows merged 3 commits into
aklivity:developfrom
akrambek:bug/begin-metadata
Dec 1, 2023
Merged

Include metadata and partitionOffset into merge reply begin#599
jfallows merged 3 commits into
aklivity:developfrom
akrambek:bug/begin-metadata

Conversation

@akrambek

@akrambek akrambek commented Dec 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

We should include metadata as part of merge reply begin ex

read zilla:begin.ext ${kafka:matchBeginEx()
                               .typeId(zilla:id("kafka"))
                               .merged()
                                   .capabilities("FETCH_ONLY")
                                   .topic("test")
                                   .partition(0, 2, 2, 2, "test-meta")
                                   .build()
                               .build()}

Fixes #601

jfallows
jfallows previously approved these changes Dec 1, 2023
View reviewed changes
@akrambek akrambek marked this pull request as ready for review December 1, 2023 18:01
@jfallows jfallows merged commit 4aae383 into aklivity:develop Dec 1, 2023
bmaidics pushed a commit to bmaidics/zilla that referenced this pull request Dec 2, 2023
@akrambek @bmaidics
REVERT!!! Include metadata and partitionOffset into merge reply begin (…
dd41ff7 
…aklivity#599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfallows jfallows jfallows approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include metadata in merge reply begin ex

2 participants

@akrambek @jfallows