Protobuf Validation & Conversion#691
Merged
Merged
Conversation
jfallows
requested changes
Jan 5, 2024
jfallows
left a comment
jfallows
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good so far!
| catalog0: | ||
| - subject: test0 | ||
| version: latest | ||
| record: SimpleMessage |
Contributor
There was a problem hiding this comment.
Does SimpleMessage not need to align with one of the message names, like example?
Also, perhaps it needs a package prefix too?
jfallows
requested changes
Jan 9, 2024
Comment on lines
+66
to
+73
| if (catalog.id != NO_SCHEMA_ID) | ||
| { | ||
| schemaId = catalog.id; | ||
| } | ||
| else | ||
| { | ||
| schemaId = handler.resolve(subject, catalog.version); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (catalog.id != NO_SCHEMA_ID) | |
| { | |
| schemaId = catalog.id; | |
| } | |
| else | |
| { | |
| schemaId = handler.resolve(subject, catalog.version); | |
| } | |
| schemaId = catalog.id != NO_SCHEMA_ID ? catalog.id : handler.resolve(subject, catalog.version); |
| DescriptorTree tree = supplyDescriptorTree(schemaId); | ||
| if (tree != null) | ||
| { | ||
| tree = tree.findByIndexes(indexes); |
Contributor
There was a problem hiding this comment.
Perhaps findByIndexes should return Descriptor directly?
Comment on lines
+156
to
+157
| builder.mergeFrom(in); | ||
| DynamicMessage message = builder.build(); |
Contributor
There was a problem hiding this comment.
Suggested change
| builder.mergeFrom(in); | |
| DynamicMessage message = builder.build(); | |
| DynamicMessage message = builder.mergeFrom(in).build(); |
| builder.mergeFrom(in); | ||
| DynamicMessage message = builder.build(); | ||
| builder.clear(); | ||
| if (!message.getUnknownFields().asMap().isEmpty()) |
Contributor
There was a problem hiding this comment.
This .asMap() still has allocation logic, but it may be the best we can do with these APIs.
Comment on lines
+178
to
+181
| catch (IOException e) | ||
| { | ||
| e.printStackTrace(); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| catch (IOException e) | |
| { | |
| e.printStackTrace(); | |
| } | |
| catch (IOException ex) | |
| { | |
| ex.printStackTrace(); | |
| } |
We typically use ex for exception variables.
Comment on lines
220
to
223
| catch (InvalidProtocolBufferException e) | ||
| { | ||
| e.printStackTrace(); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| catch (InvalidProtocolBufferException e) | |
| { | |
| e.printStackTrace(); | |
| } | |
| catch (InvalidProtocolBufferException ex) | |
| { | |
| ex.printStackTrace(); | |
| } |
| in.wrap(buffer, index, length); | ||
| DynamicMessage message = DynamicMessage.parseFrom(descriptor, in); | ||
| status = message.getUnknownFields().asMap().isEmpty(); | ||
| padding = 2 + JsonFormat.printer().print(descriptor.toProto()).length(); |
Contributor
There was a problem hiding this comment.
Perhaps we should reuse this printer?
How often is this method called when messages are flowing?
Why 2 + ...? Suggest using a constant to better document the intent.
Comment on lines
+138
to
+141
| catch (IOException e) | ||
| { | ||
| e.printStackTrace(); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| catch (IOException e) | |
| { | |
| e.printStackTrace(); | |
| } | |
| catch (IOException ex) | |
| { | |
| ex.printStackTrace(); | |
| } |
| int valLength = 0; | ||
| if (indexes.size() == 2 && indexes.get(0) == 1 && indexes.get(1) == 0) | ||
| { | ||
| indexesRO.wrap(new byte[]{ZERO_INDEX}); |
Contributor
There was a problem hiding this comment.
This byte[] should be a constant.
Comment on lines
+202
to
+205
| catch (IOException e) | ||
| { | ||
| e.printStackTrace(); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| catch (IOException e) | |
| { | |
| e.printStackTrace(); | |
| } | |
| catch (IOException ex) | |
| { | |
| ex.printStackTrace(); | |
| } |
jfallows
approved these changes
Jan 10, 2024
This was
linked to
issues
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #457
Fixes #458