Mqtt-kafka single group support cont #731
Applied feedback from PR
- Loading branch information
commit 196b0ba506a731fafbf560572786148be18a4980
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| # | ||
| # Copyright 2021-2023 Aklivity Inc. | ||
| # | ||
| # Aklivity licenses this file to you under the Apache License, | ||
| # version 2.0 (the "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at: | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
|
|
||
| property deltaMillis 0L | ||
| property newTimestamp ${kafka:timestamp() + deltaMillis} | ||
|
|
||
| connect "zilla://streams/app0" | ||
| option zilla:window 8192 | ||
| option zilla:transmission "half-duplex" | ||
|
|
||
| write zilla:begin.ext ${kafka:beginEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .meta() | ||
| .topic("test") | ||
| .build() | ||
| .build()} | ||
|
|
||
| connected | ||
|
|
||
| read zilla:begin.ext ${kafka:beginEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .meta() | ||
| .topic("test") | ||
| .build() | ||
| .build()} | ||
|
|
||
| read zilla:data.ext ${kafka:dataEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .meta() | ||
| .partition(0, 177) | ||
| .build() | ||
| .build()} | ||
|
|
||
| read notify ROUTED_BROKER_CLIENT | ||
|
|
||
| connect await ROUTED_BROKER_CLIENT | ||
| "zilla://streams/app0" | ||
| option zilla:window 8192 | ||
| option zilla:transmission "half-duplex" | ||
| option zilla:affinity 0xb1 | ||
|
|
||
| write zilla:begin.ext ${kafka:beginEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .produce() | ||
| .topic("test") | ||
| .partition(0) | ||
| .build() | ||
| .build()} | ||
|
|
||
| connected | ||
|
|
||
| read zilla:begin.ext ${kafka:beginEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .produce() | ||
| .topic("test") | ||
| .partition(0) | ||
| .build() | ||
| .build()} | ||
|
|
||
| write zilla:data.ext ${kafka:dataEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .produce() | ||
| .timestamp(newTimestamp) | ||
| .producerId(1) | ||
| .producerEpoch(1) | ||
| .sequence(0) | ||
| .build() | ||
| .build()} | ||
| write "Hello, world" | ||
| write flush | ||
|
|
||
| write zilla:data.ext ${kafka:dataEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .produce() | ||
| .timestamp(newTimestamp) | ||
| .producerId(2) | ||
| .producerEpoch(2) | ||
| .sequence(0) | ||
| .build() | ||
| .build()} | ||
| write "Hello, again" | ||
| write flush |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| # | ||
| # Copyright 2021-2023 Aklivity Inc. | ||
| # | ||
| # Aklivity licenses this file to you under the Apache License, | ||
| # version 2.0 (the "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at: | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
|
|
||
| property serverAddress "zilla://streams/app0" | ||
|
|
||
| accept ${serverAddress} | ||
| option zilla:window 8192 | ||
| option zilla:padding 512 | ||
| option zilla:transmission "half-duplex" | ||
|
|
||
| accepted | ||
|
|
||
| read zilla:begin.ext ${kafka:beginEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .meta() | ||
| .topic("test") | ||
| .build() | ||
| .build()} | ||
|
|
||
| connected | ||
|
|
||
| write zilla:begin.ext ${kafka:beginEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .meta() | ||
| .topic("test") | ||
| .build() | ||
| .build()} | ||
| write flush | ||
|
|
||
| write zilla:data.ext ${kafka:dataEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .meta() | ||
| .partition(0, 177) | ||
| .build() | ||
| .build()} | ||
| write flush | ||
|
|
||
| accepted | ||
|
|
||
| read zilla:begin.ext ${kafka:beginEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .produce() | ||
| .topic("test") | ||
| .partition(0) | ||
| .build() | ||
| .build()} | ||
|
|
||
| connected | ||
|
|
||
| write zilla:begin.ext ${kafka:beginEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .produce() | ||
| .topic("test") | ||
| .partition(0) | ||
| .build() | ||
| .build()} | ||
|
|
||
| read zilla:data.ext ${kafka:matchDataEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .produce() | ||
| .producerId(1) | ||
| .producerEpoch(1) | ||
| .sequence(0) | ||
| .build() | ||
| .build()} | ||
|
|
||
| read "Hello, world" | ||
|
|
||
| read zilla:data.ext ${kafka:matchDataEx() | ||
| .typeId(zilla:id("kafka")) | ||
| .produce() | ||
| .producerId(2) | ||
| .producerEpoch(2) | ||
| .sequence(0) | ||
| .build() | ||
| .build()} | ||
|
|
||
| read "Hello, again" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to reset
producerIdandproducerEpochafter encoding request so that next request can batch as expected?