Add event logs to open telemetry exporter#839
Merged
Conversation
attilakreiner
force-pushed
the
otlp-logs
branch
from
9a02601 to
0bab037
Compare
attilakreiner
force-pushed
the
otlp-logs
branch
from
0bab037 to
39c2286
Compare
jfallows
requested changes
Mar 11, 2024
jfallows
reviewed
Mar 12, 2024
jfallows
left a comment
jfallows
left a comment
Contributor
There was a problem hiding this comment.
Apologies, I think I may have misinterpreted our intent for overrides, I think we need to revert that change.
I was thinking why we need to have overrides in the config, when we already have location, and it seemed to be for override like we do in other places.
However, it turns out the override is to give us flexibility in the path endpoint for metrics / events while specifying the location url once, while going with standard path defaults when only the location is specified.
This reverts commit 1544c29.
jfallows
approved these changes
Mar 13, 2024
ankitk-me
pushed a commit
to ankitk-me/zilla
that referenced
this pull request
Mar 14, 2024
This was referenced Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds the feaure to send event logs to the open telemetry exporter.
Fixes #785