Skip to content

Implement JoinGroup request as first class stream #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfallows merged 6 commits into from
Mar 12, 2024
Merged

Implement JoinGroup request as first class stream #844

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e9bfc8
WIP
akrambek Mar 7, 2024
ed25348
WIP
akrambek Mar 11, 2024
6add5fc
WIP
akrambek Mar 12, 2024
1bb8a31
Update scripts
akrambek Mar 12, 2024
08be1c4
WIP
akrambek Mar 12, 2024
e448b35
Apply feedback from PR
akrambek Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
WIP
  • Loading branch information
@akrambek
akrambek committed Mar 7, 2024
commit 0e9bfc8f005461836d44f39fa323a13527ac0ea0
2 changes: 1 addition & 1 deletion ...ka/src/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/KafkaConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public class KafkaConfiguration extends Configuration
static
{
final ConfigurationDef config = new ConfigurationDef("zilla.binding.kafka");
KAFKA_CLIENT_ID = config.property("client.id");
KAFKA_CLIENT_ID = config.property("client.id", "zilla");
KAFKA_CLIENT_INSTANCE_ID = config.property(InstanceIdSupplier.class, "client.instance.id",
KafkaConfiguration::decodeInstanceId, KafkaConfiguration::defaultInstanceId);
KAFKA_CLIENT_MAX_IDLE_MILLIS = config.property("client.max.idle.ms", 1 * 60 * 1000);
Expand Down
Loading