-
Notifications
You must be signed in to change notification settings - Fork 70
unify caching across workers to maximize cache hits #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d6dffb6
unify caching across workers to maximize cache hits
ankitk-me d778b9e
addressing review comments
ankitk-me 6844810
addressing review comments
ankitk-me 04ee960
including event log for FutureCompletedExceptionally & StaleSchemaServed
ankitk-me da28dd7
update to handle unifying cache getting access by other catalog instance
ankitk-me 4602867
checkstyle fix
ankitk-me e6d7cf5
using computeIfAbsent
ankitk-me d92bc16
addressing review comments
ankitk-me 0027f5f
adding support for progressive back off
ankitk-me 3485813
addressing review comments
ankitk-me dc244a6
stale schema logging fix
ankitk-me 0ce3f55
addressing review comments
ankitk-me 62c8220
updating IT to use zilla.yaml instead of mock & handler
ankitk-me 4fba34f
Merge remote-tracking branch 'origin' into unify_caching
ankitk-me 0fd0060
addressing review comments
ankitk-me File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
...apace/src/main/java/io/aklivity/zilla/runtime/catalog/karapace/internal/CachedSchema.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* | ||
| * Copyright 2021-2023 Aklivity Inc | ||
| * | ||
| * Licensed under the Aklivity Community License (the "License"); you may not use | ||
| * this file except in compliance with the License. You may obtain a copy of the | ||
| * License at | ||
| * | ||
| * https://www.aklivity.io/aklivity-community-license/ | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
| package io.aklivity.zilla.runtime.catalog.karapace.internal; | ||
|
|
||
| import java.util.concurrent.atomic.AtomicInteger; | ||
|
|
||
| public class CachedSchema | ||
| { | ||
| public static final String SCHEMA_PLACEHOLDER = "schema"; | ||
| public static final CachedSchema IN_PROGRESS = new CachedSchema(SCHEMA_PLACEHOLDER); | ||
|
|
||
| public final String schema; | ||
| public final AtomicInteger retryAttempts; | ||
|
|
||
| public CachedSchema( | ||
| String schema) | ||
| { | ||
| this.schema = schema; | ||
| this.retryAttempts = new AtomicInteger(); | ||
| } | ||
|
|
||
| public CachedSchema( | ||
| String schema, | ||
| AtomicInteger retryAttempts) | ||
| { | ||
| this.schema = schema; | ||
| this.retryAttempts = retryAttempts; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
...pace/src/main/java/io/aklivity/zilla/runtime/catalog/karapace/internal/KarapaceCache.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /* | ||
| * Copyright 2021-2023 Aklivity Inc | ||
| * | ||
| * Licensed under the Aklivity Community License (the "License"); you may not use | ||
| * this file except in compliance with the License. You may obtain a copy of the | ||
| * License at | ||
| * | ||
| * https://www.aklivity.io/aklivity-community-license/ | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
| package io.aklivity.zilla.runtime.catalog.karapace.internal; | ||
|
|
||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
| import java.util.concurrent.ConcurrentMap; | ||
|
|
||
| public class KarapaceCache | ||
| { | ||
| public final ConcurrentMap<Integer, CompletableFuture<CachedSchema>> schemas; | ||
| public final ConcurrentMap<Integer, CompletableFuture<CachedSchemaId>> schemaIds; | ||
|
|
||
| public KarapaceCache() | ||
| { | ||
| this.schemas = new ConcurrentHashMap<>(); | ||
| this.schemaIds = new ConcurrentHashMap<>(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to have a convenience constructor with just
schemadefauting tonew AtomicInteger().