Skip to content

Clears Actions.currentRouter when unmounting ExRouter if this is the … #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2016
Merged

Clears Actions.currentRouter when unmounting ExRouter if this is the … #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Clears Actions.currentRouter when unmounting ExRouter if this is the … 
…current router's ExRouter instance. Fixes #172
  • Loading branch information
@danielweinmann
danielweinmann committed Feb 4, 2016
commit 8943828d90bd5ccee2bb4ed5f0db9017d1077e40
6 changes: 6 additions & 0 deletions ExRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,12 @@ export default class ExRouter extends React.Component {
this.state = {};
}

componentWillUnmount() {
if (this === Actions.currentRouter.delegate) {
Actions.currentRouter = null;
}
}

onPush(route: Route, props:{ [key: string]: any}):boolean {
if (this.props.onPush){
const res = this.props.onPush(route, props);
Expand Down