Skip to content

BaseRouter bug fix, add route data when dispatch BEFORE_FOCUS, AFTER_FOCUS #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2016
Merged

BaseRouter bug fix, add route data when dispatch BEFORE_FOCUS, AFTER_FOCUS #222

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29e9a80
BaseRouter bug fix - never call this["_"+action](name,props); in route
jungsoo108 Feb 18, 2016
97ef6b1
add data 'route' when dispatch Actions BEFORE_FOCUS, AFTER_FOCUS
jungsoo108 Feb 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
BaseRouter bug fix - never call this["_"+action](name,props); in route
  • Loading branch information
@jungsoo108
jungsoo108 committed Feb 18, 2016
commit 29e9a8027b7ea8b85b9a9c5663965629c95607f9
2 changes: 1 addition & 1 deletion BaseRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export default class BaseRouter {
} else {
throw new Error("No handler "+handler+" for route="+name);
}
if (!this["_"+action]) {
if (this["_"+action]) {
this["_" + action](name, props);
}
return true;
Expand Down