Skip to content

Use route props first when determining route title #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Mar 5, 2016
Merged

Use route props first when determining route title #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use route props first when determining route title 
When invoking Actions.refresh({title: 'Changed'}), the call to
super.render() in ExNavigationBar calls back into getTitle() on
ExRouteAdapter to determine the title to display in the navigation bar
This patch first checks the provided props before falling back to the
previous behavior.
  • Loading branch information
Joe O'Pecko committed Mar 5, 2016
commit a790262d55ac9cc060ed5c07faa5fa5e75636786
5 changes: 3 additions & 2 deletions ExRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,9 @@ export class ExRouteAdapter {
}

getTitle() {
debug("TITLE ="+this.route.title+" for route="+this.route.name);
return this.title || "";
const title = this.route.props.title || this.title || "";
debug("TITLE ="+title+" for route="+this.route.name);
return title;
}

getBackButtonTitle(navigator, index, state){
Expand Down