Skip to content

Make pop work on invisible component #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2016
Merged

Make pop work on invisible component #313

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
686702d
Merge pull request #5 from aksonov/master
lrettig Mar 7, 2016
e0db8f1
add third arg to Actions.pop, allowing a view to be popped off a curr…
lrettig Mar 7, 2016
9cc723d
bugfix in last commit
lrettig Mar 8, 2016
76e670d
Merge pull request #6 from aksonov/master
lrettig Mar 9, 2016
6a7fec1
add pop method to Route, allowing this.props.route.pop() inside compo…
lrettig Mar 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add pop method to Route, allowing this.props.route.pop() inside compo… 
…nents
  • Loading branch information
@lrettig
lrettig committed Mar 14, 2016
commit 6a7fec1db3922d83f1a760646e8a3dd548e4d243
8 changes: 6 additions & 2 deletions Route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*
*/

import Actions from './Actions';
import type BaseRouter from './BaseRouter';
export default class Route {
name: string;
Expand Down Expand Up @@ -41,7 +42,10 @@ export default class Route {
this.footer = footer;
this.props = props;
this.wrapRouter = wrapRouter || type=='switch';

this.pop = this.pop.bind(this)
}

}
pop(num: number = 1, props: { [key: string]: any} = {}) {
Actions.pop(num, props, this.parent);
}
}