Skip to content

Added action type: 'pushToCurrent' #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Added action type: 'pushToCurrent' #389

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0e9548
- Added action type: 'pushToCurrent': first finds the current scene's…
joenoon Mar 24, 2016
8645410
create ephemeral scenes during pushToCurrent. because these scenes a…
joenoon Mar 24, 2016
97612c8
ensure we dont overwrite anything in scenes map
joenoon Mar 24, 2016
6e30fe3
treat all pushes as ephemeral. they get cloned with a unique key
joenoon Mar 24, 2016
7230d16
handle ephemeral case different for refresh.
joenoon Mar 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ensure we dont overwrite anything in scenes map
  • Loading branch information
@joenoon
joenoon committed Mar 24, 2016
commit 97612c8480b1ce322f89bf97f70e0f5de45e6422
1 change: 1 addition & 0 deletions src/Reducer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ function update(state,action){
el.index = el.children.length - 1;
newState.scenes.current = getCurrent(newState).key;
if (newProps.ephemeral) {
assert(!newState.scenes.hasOwnProperty(newState.scenes.current), "scenes should not contain ephemeral key="+newState.scenes.current);
newState.scenes[newState.scenes.current] = newProps;
}
return newState;
Expand Down