Skip to content

Feature/override images #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2016
Merged

Feature/override images #411

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12cdd87
doc(readme): Added properties for image overrides
RWOverdijk Mar 27, 2016
e6e7825
feat(navbar): Allow overriding images
RWOverdijk Mar 27, 2016
e4d38a6
chore(navbar): Remove extra bracket
RWOverdijk Mar 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore(navbar): Remove extra bracket
  • Loading branch information
@RWOverdijk
RWOverdijk committed Mar 27, 2016
commit e4d38a646fe10fa2686dd4e11938037cc5f24f46
2 changes: 1 addition & 1 deletion src/NavBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default class NavBar extends React.Component {
var drawer = this.context.drawer;
drawer.toggle();
}}>
<Image source={backButtonImage)} style={[styles.backButtonImage, this.props.navigationState.barButtonIconStyle]}/>
<Image source={backButtonImage} style={[styles.backButtonImage, this.props.navigationState.barButtonIconStyle]}/>
Copy link
Contributor

@Froelund Froelund Mar 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming backButtonImage to buttonImage, as it is used for both drawerImage and backButtonImage. For readability.

Copy link
Contributor Author

@RWOverdijk RWOverdijk Mar 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Froelund Fair enough. See: #420

</TouchableOpacity>
);
}else{
Expand Down