Skip to content

Check properties sended in route are equal to prevent pushing new routes #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Check properties sended in route are equal to prevent pushing new routes #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Reducer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,20 @@ import assert from 'assert';
import Immutable from 'immutable';
import {getInitialState} from './State';

const checkPropertiesEqual = (action, lastAction) => {
let isEqual = true;
for(let i in action) {
if(action.hasOwnProperty(i) && ['key', 'type', 'parent'].indexOf(i) == -1) {//property is passed as argument
if(action[i] != lastAction[i]) {
isEqual = false;
}
}
}

return isEqual;

}

function inject(state, action, props, scenes) {
const condition = action.type == REFRESH_ACTION ? state.key === props.key || state.sceneKey === action.key : state.sceneKey == props.parent;
if (!condition){
Expand All @@ -37,7 +51,7 @@ function inject(state, action, props, scenes) {
case REFRESH_ACTION:
return {...state, ...props};
case PUSH_ACTION:
if (state.children[state.index].sceneKey == action.key && !props.clone){
if (state.children[state.index].sceneKey == action.key && !props.clone && checkPropertiesEqual(action, state.children[state.index])){
return state;
}
return {...state, index:state.index+1, children:[...state.children, getInitialState(props, scenes, state.index + 1, action)]};
Expand Down