Skip to content

[WIP] Get Example app working with React 0.24+ #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 18, 2016
Merged

[WIP] Get Example app working with React 0.24+ #536

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3561582
direction support for rn 0.24+
joenoon Apr 11, 2016
1256e03
fix || logic and optimize duration 0
joenoon Apr 11, 2016
ea8aad1
Merge pull request #1 from aksonov/master
cridenour Apr 17, 2016
aa74423
Bump example project dependency.
cridenour Apr 17, 2016
a3a6087
Merge branch 'jn-direction1' of github.com:joenoon/react-native-route…
cridenour Apr 17, 2016
1f2c98c
Cleanup styles and unused imports.
cridenour Apr 17, 2016
495c794
Remove optionals.
cridenour Apr 17, 2016
546c00c
Make sure panHandler can be passed as null.
cridenour Apr 17, 2016
6aac7bd
Actually run react-native upgrade.
cridenour Apr 17, 2016
ff69aaa
Document why we removed optionals.
cridenour Apr 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix || logic and optimize duration 0
  • Loading branch information
@joenoon
joenoon committed Apr 11, 2016
commit 1256e03cae02e9d3e4bb2a2f9dbfdb3a0bd65b52
14 changes: 9 additions & 5 deletions src/DefaultRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ export default class DefaultRenderer extends Component {
if (duration === null || duration === undefined) duration = navigationState.duration;
if (duration !== null && duration !== undefined) {
optionals.applyAnimation = function (pos, navState) {
Animated.timing(pos, {toValue: navState.index, duration}).start();
if (duration === 0) {
pos.setValue(navState.index);
} else {
Animated.timing(pos, {toValue: navState.index, duration}).start();
}
};
}
}
Expand All @@ -90,13 +94,13 @@ export default class DefaultRenderer extends Component {
_renderCard(/*NavigationSceneRendererProps*/ props) {
const isVertical = props.scene.navigationState.direction === "vertical";

const animationStyle = props.scene.navigationState.animationStyle || isVertical ?
const animationStyle = props.scene.navigationState.animationStyle || (isVertical ?
NavigationCardStackStyleInterpolator.forVertical(props) :
NavigationCardStackStyleInterpolator.forHorizontal(props);
NavigationCardStackStyleInterpolator.forHorizontal(props));

const panHandlers = props.scene.navigationState.panHandlers || isVertical ?
const panHandlers = props.scene.navigationState.panHandlers || (isVertical ?
NavigationCardStackPanResponder.forVertical(props) :
NavigationCardStackPanResponder.forHorizontal(props);
NavigationCardStackPanResponder.forHorizontal(props));

return (
<NavigationCard
Expand Down