Add support for nightly and rc versions #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsafonkin
approved these changes
Oct 20, 2022
e-korolevskii
suggested changes
Oct 20, 2022
src/installer.ts
Outdated
Comment on lines
386
to
403
| versions = versions.sort((a, b) => { | ||
| if (semver.gt(a, b)) { | ||
| return 1; | ||
| } | ||
| return -1; | ||
| }); | ||
| for (let i = versions.length - 1; i >= 0; i--) { | ||
| const potential: string = versions[i]; | ||
| const satisfied: boolean = semver.satisfies( | ||
| potential.replace('-nightly', '-nightly.'), | ||
| range, | ||
| {includePrerelease: true} | ||
| ); | ||
| if (satisfied) { | ||
| version = potential; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| versions = versions.sort((a, b) => { | |
| if (semver.gt(a, b)) { | |
| return 1; | |
| } | |
| return -1; | |
| }); | |
| for (let i = versions.length - 1; i >= 0; i--) { | |
| const potential: string = versions[i]; | |
| const satisfied: boolean = semver.satisfies( | |
| potential.replace('-nightly', '-nightly.'), | |
| range, | |
| {includePrerelease: true} | |
| ); | |
| if (satisfied) { | |
| version = potential; | |
| break; | |
| } | |
| } | |
| versions.sort((a, b) => semver.lt(a, b) * 1 - 0.5); | |
| for (const currentVersion of versions) { | |
| const satisfied: boolean = semver.satisfies( | |
| currentVersion.replace("-nightly", "-nightly."), | |
| range, | |
| { includePrerelease: true } | |
| ); | |
| if (satisfied) { | |
| version = currentVersion; | |
| break; | |
| } | |
| } |
There was a problem hiding this comment.
Uuuu @e-korolevskii has a few aces up in his sleeve :D
src/installer.ts
Outdated
Comment on lines
452
to
456
| } else if (!prerelease) { | ||
| return 'https://nodejs.org/dist'; | ||
| } else { | ||
| return 'https://nodejs.org/download/rc'; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else if (!prerelease) { | |
| return 'https://nodejs.org/dist'; | |
| } else { | |
| return 'https://nodejs.org/download/rc'; | |
| } | |
| } else if (prerelease) { | |
| return 'https://nodejs.org/download/rc'; | |
| } | |
| return 'https://nodejs.org/dist'; |
marko-zivic-93
approved these changes
Oct 20, 2022
src/installer.ts
Outdated
Comment on lines
386
to
403
| versions = versions.sort((a, b) => { | ||
| if (semver.gt(a, b)) { | ||
| return 1; | ||
| } | ||
| return -1; | ||
| }); | ||
| for (let i = versions.length - 1; i >= 0; i--) { | ||
| const potential: string = versions[i]; | ||
| const satisfied: boolean = semver.satisfies( | ||
| potential.replace('-nightly', '-nightly.'), | ||
| range, | ||
| {includePrerelease: true} | ||
| ); | ||
| if (satisfied) { | ||
| version = potential; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Uuuu @e-korolevskii has a few aces up in his sleeve :D
marko-zivic-93
approved these changes
Oct 24, 2022
e-korolevskii
approved these changes
Oct 24, 2022
e-korolevskii
left a comment
e-korolevskii
left a comment
There was a problem hiding this comment.
Overall looks great, a couple of small suggestions
| const prerelease = semver.prerelease(version); | ||
| if (version.includes('nightly')) { | ||
| return 'https://nodejs.org/download/nightly'; | ||
| } else if (prerelease) { |
There was a problem hiding this comment.
Unnecessary else statement
Suggested change
| } else if (prerelease) { | |
| } | |
| if (prerelease) { |
src/installer.ts
Outdated
| } | ||
|
|
||
| if (range) { | ||
| versions.sort((a, b) => +semver.lt(a, b) * 1 - 0.5); |
There was a problem hiding this comment.
Unnecessary operation "* 1" because it is already being cast to a number by the "+" operator
Suggested change
| versions.sort((a, b) => +semver.lt(a, b) * 1 - 0.5); | |
| versions.sort((a, b) => +semver.lt(a, b) - 0.5); |
Comment on lines
+443
to
+448
| const prerelease = semver.prerelease(version); | ||
| if (version.includes('nightly')) { | ||
| return 'https://nodejs.org/download/nightly'; | ||
| } else if (prerelease) { | ||
| return 'https://nodejs.org/download/rc'; | ||
| } |
There was a problem hiding this comment.
Suggested change
| const prerelease = semver.prerelease(version); | |
| if (version.includes('nightly')) { | |
| return 'https://nodejs.org/download/nightly'; | |
| } else if (prerelease) { | |
| return 'https://nodejs.org/download/rc'; | |
| } | |
| if (version.includes('nightly')) { | |
| return 'https://nodejs.org/download/nightly'; | |
| } | |
| const prerelease = semver.prerelease(version); | |
| if (prerelease) { | |
| return 'https://nodejs.org/download/rc'; | |
| } |
There was a problem hiding this comment.
It makes sense to declare this constant after the first conditional statement.
Comment on lines
+99
to
+105
| if (initialUrl.endsWith('/rc')) { | ||
| return <im.INodeVersion>nodeTestDistRc; | ||
| } else if (initialUrl.endsWith('/nightly')) { | ||
| return <im.INodeVersion>nodeTestDistNightly; | ||
| } else { | ||
| return <im.INodeVersion>nodeTestDist; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (initialUrl.endsWith('/rc')) { | |
| return <im.INodeVersion>nodeTestDistRc; | |
| } else if (initialUrl.endsWith('/nightly')) { | |
| return <im.INodeVersion>nodeTestDistNightly; | |
| } else { | |
| return <im.INodeVersion>nodeTestDist; | |
| } | |
| if (initialUrl.endsWith('/rc')) { | |
| return <im.INodeVersion>nodeTestDistRc; | |
| } | |
| if (initialUrl.endsWith('/nightly')) { | |
| return <im.INodeVersion>nodeTestDistNightly; | |
| } | |
| return <im.INodeVersion>nodeTestDist; |
marko-zivic-93
approved these changes
Oct 25, 2022
panticmilos
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Describe your changes.
Related issue:
Add link to the related issue.
Check list: