Skip to content

Fix reaction-diffusion example and update GP predictive#639

Merged
sgreenbury merged 8 commits intomainfrom
618-compare-performance
Jul 22, 2025
Merged

Fix reaction-diffusion example and update GP predictive#639
sgreenbury merged 8 commits intomainfrom
618-compare-performance

Conversation

@sgreenbury
Copy link
Collaborator

Closes #618.

This PR:

  • Fixes discrepancies with v0 reaction-diffusion example
  • Revises default GP parameters to those for v0
  • Adds posterior_predictive bool to GP init that enables learned observation noise to be incorporated at inference time

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sgreenbury sgreenbury force-pushed the 618-compare-performance branch from 6d22915 to 877776b Compare July 21, 2025 21:33
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate/experimental/emulators/gaussian_process
  exact.py 211-213
Project Total  

This report was generated by python-coverage-comment-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.37%. Comparing base (21653a0) to head (877776b).

Files with missing lines Patch % Lines
...e/experimental/emulators/gaussian_process/exact.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   78.38%   78.37%   -0.02%     
==========================================
  Files         150      150              
  Lines       10805    10813       +8     
==========================================
+ Hits         8470     8475       +5     
- Misses       2335     2338       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@radka-j radka-j self-requested a review July 22, 2025 07:26
Copy link
Member

@radka-j radka-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@sgreenbury sgreenbury merged commit 8d60dfe into main Jul 22, 2025
4 checks passed
@sgreenbury sgreenbury deleted the 618-compare-performance branch July 22, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compare performance for transformed emulator and current pipeline

3 participants