Skip to content

Yanjun Jiang A2 Submission #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Yanjun Jiang A2 Submission #27

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bd8893
A2
Yanjun7J Feb 6, 2018
527e39c
Delete unnecessary comments
Yanjun7J Feb 6, 2018
2c084d6
One line of modification that makes the code works both in Release Mo…
Yanjun7J Feb 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
One line of modification that makes the code works both in Release Mo… 
…de and Debug Mode. The code was previously tested in Release Mode and should work properly there.
  • Loading branch information
@Yanjun7J
Yanjun7J committed Feb 8, 2018
commit 2c084d6fe5ce7f171deeed244f67bd844b71219a
2 changes: 1 addition & 1 deletion src/closest_rotation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ void closest_rotation(
using namespace Eigen;

// Calculate UV
JacobiSVD<Matrix3d> svd(M, ComputeThinU | ComputeThinV);
JacobiSVD<MatrixXd> svd(M, ComputeThinU | ComputeThinV);
Matrix3d U, V, omega;
U = svd.matrixU();
V = svd.matrixV();
Expand Down