Skip to content

Add candlestick chart, plus maintainance #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 19, 2020
Merged

Add candlestick chart, plus maintainance #226

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e6800a6
add cadlestick chart
igorfialko Apr 11, 2020
c07b479
Minimize binary compatibility breaking
alexarchambault Oct 19, 2020
53d3409
Back to sbt-mima mainline
alexarchambault Oct 19, 2020
0d5adbe
Add .bsp to .gitignore
alexarchambault Oct 19, 2020
bc17090
Add Range data type
alexarchambault Oct 19, 2020
c731210
Accept local date times without seconds
alexarchambault Oct 19, 2020
bf977c4
Disable mima check for core until 0.8.0
alexarchambault Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Accept local date times without seconds
  • Loading branch information
@alexarchambault
alexarchambault committed Oct 19, 2020
commit c73121008ce0e41aac42b64a8b3e98b808cb3ed3
2 changes: 2 additions & 0 deletions core/shared/src/main/scala/plotly/element/LocalDateTime.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ object LocalDateTime extends PlotlyJavaTimeConversions {
(d.split('-'), t.split(':')) match {
case (Array(IntStr(y), IntStr(m), IntStr(d)), Array(IntStr(h), IntStr(min), IntStr(s))) =>
Some(LocalDateTime(y, m, d, h, min, s))
case (Array(IntStr(y), IntStr(m), IntStr(d)), Array(IntStr(h), IntStr(min))) =>
Some(LocalDateTime(y, m, d, h, min, 0))
case _ => None
}
case _ => None
Expand Down