Avoid passing null_mut() to ptr::offset.
#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split `Chunk::mem_offset` out of `Chunk::to_mem`, and use that to avoid passing a null pointer to `Chunk::to_mem`, which calls `ptr::offset`, which Miri diagnoses as Undefined Behavior. Fixes alexcrichton#19.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
Chunk::mem_offsetout ofChunk::to_mem, and use that to avoidpassing a null pointer to
Chunk::to_mem, which callsptr::offset,which Miri diagnoses as Undefined Behavior.
Fixes #19.