Skip to content

unify linux and macos into a single module #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexcrichton merged 1 commit into from
Oct 27, 2021
Merged

unify linux and macos into a single module #23

alexcrichton merged 1 commit into from
Oct 27, 2021

Conversation

@nivkner
Copy link
Contributor

@nivkner nivkner commented Oct 26, 2021

the linux and macos versions are more similar than they are different, having to write to versions of the same code is unnecessary.

also acording to https://man7.org/linux/man-pages/man2/mmap.2.html

MAP_ANON
              Synonym for MAP_ANONYMOUS; provided for compatibility with
              other implementations.

@alexcrichton alexcrichton merged commit fb9bb77 into alexcrichton:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nivkner @alexcrichton