Skip to content

Further size optimization #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeyraspopov merged 8 commits into from
Oct 13, 2021
+46 −47
Merged

Further size optimization #31

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
da1ea1e
convert named functions to arrow ones
borodean Oct 4, 2021
873b46d
reorganize functions code to make them shorter
borodean Oct 4, 2021
7f2e07b
embed createColors to the default export directly
borodean Oct 4, 2021
055f351
reorganize isColorSupported to make it shorter
borodean Oct 4, 2021
68c5a18
reorganize functions code again to preserve the speed
borodean Oct 5, 2021
ae5732a
Revert "embed createColors to the default export directly"
borodean Oct 5, 2021
ee496e7
Revert "reorganize isColorSupported to make it shorter"
borodean Oct 5, 2021
d9e59b8
omit parens when possible
borodean Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reorganize functions code to make them shorter
  • Loading branch information
@borodean
borodean committed Oct 12, 2021
commit 873b46dc295152ae4ea99839b8dcee28d1298864
11 changes: 6 additions & 5 deletions picocolors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,17 @@ let formatter =
(input) => {
Copy link
Contributor

@ai ai Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going this way, should we change Prettier settings to reduce ( and ) for single argument function?

Copy link
Contributor Author

@borodean borodean Oct 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense if we're all-in on squeezing every byte out of it: ed55367.

let string = "" + input
let index = string.indexOf(close, open.length)
return !~index
? open + string + close
: open + replaceClose(string, close, replace, index) + close
return open + (~index ? replaceClose(string, close, replace, index) : string) + close
Copy link
Owner

@alexeyraspopov alexeyraspopov Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This most likely affects benchmarks. I tried to use ternary operator within a concat expression and always saw notable drop in performance (see complex benchmark)

Copy link
Contributor Author

@borodean borodean Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Updated in a way that is still shorter, but preserves the original logic: 000f178.

}

let replaceClose = (string, close, replace, index) => {
let start = string.substring(0, index) + replace
let end = string.substring(index + close.length)
let nextIndex = end.indexOf(close)
return !~nextIndex ? start + end : start + replaceClose(end, close, replace, nextIndex)
return (
string.substring(0, index) +
replace +
(~nextIndex ? replaceClose(end, close, replace, nextIndex) : end)
)
}

let createColors = (enabled = isColorSupported) => ({
Expand Down