Skip to content

fix: iteratively replace "close" to avoid maximum stack error #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeyraspopov merged 2 commits into from
May 14, 2024
+8 −4
Merged

fix: iteratively replace "close" to avoid maximum stack error #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3236f18
fix: iteratively replace "close" to avoid maximum stack error
hi-ogawa May 10, 2024
898d93d
perf: apply suggestion to special case initial check
hi-ogawa May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions picocolors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,14 @@ let formatter =
}

let replaceClose = (string, close, replace, index) => {
let start = string.substring(0, index) + replace
let end = string.substring(index + close.length)
let nextIndex = end.indexOf(close)
return ~nextIndex ? start + replaceClose(end, close, replace, nextIndex) : start + end
let result = ""
let cursor = 0
do {
result += string.substring(cursor, index) + replace
cursor = index + close.length
index = string.indexOf(close, cursor)
} while (~index)
return result + string.substring(cursor)
}

let createColors = (enabled = isColorSupported) => ({
Expand Down