MAGE-1383 Codacy quality checks 3.17 #1842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammonro
commented
Oct 2, 2025
damcou
approved these changes
Oct 2, 2025
Contributor
damcou
left a comment
damcou
left a comment
There was a problem hiding this comment.
🚀 Good job !
One small typo I think, but you can merge afterwards
Co-authored-by: Damien Couchez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to address Codacy code quality checks for PHPCS sniff
Generic.PHP.ForbiddenFunctions(does not flag with version 3 of PHPCS but Codacy complains).