This repository was archived by the owner on Dec 15, 2022. It is now read-only.
fix(geo): update Algolia theme #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for instantsearch-css ready! Built with commit 91a96d8 |
Haroenv
approved these changes
Sep 24, 2018
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
I can see it's placed more correctly now
sarahdayan
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
* feat(geo): use block for the label * fix(geo): override default browser input
sarahdayan
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
* feat(geo): use block for the label * fix(geo): override default browser input
sarahdayan
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 15, 2022
* feat(geo): use block for the label * fix(geo): override default browser input
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous theme rely on the browser default (it's inconsistent) for the margin input. This PR reproduce the same with a fixed margin. I've also set the box model of the label to block. It fixes an issue where the button & label was not exactly at the same place.