This repository was archived by the owner on Dec 15, 2022. It is now read-only.
fix(CurrentRefinement): sync option name #88
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep both option related to `query` in sync between `CurrentRefinements` and `ClearRefinements`. - `CurrentRefinement`: `includesQuery` → `clearsQuery` - `ClearRefinements`: `clearsQuery`
|
Deploy preview for instantsearch-css ready! Built with commit 90b955a |
Haroenv
reviewed
Oct 12, 2018
| - name: excludedAttributes | ||
| description: The list of attributes to filter out included attributes | ||
| - name: includesQuery | ||
| - name: clearsQuery |
Contributor
There was a problem hiding this comment.
I think we can have a proper API if we do excudedAttributes=['query'], remove includeQuery and clearsQuery
Contributor
Author
There was a problem hiding this comment.
Yep I agree - but do we want to have the query by default? Not sure, let's discuss about that.
Contributor
Author
|
Not relevant anymore. We dropped the support of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep both option related to
queryin sync betweenCurrentRefinementsandClearRefinements.CurrentRefinement:includesQuery→clearsQueryClearRefinements:clearsQuery