Skip to content

feat(clearRefinements): implement InstantSearch.css #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobylito merged 13 commits into from
Sep 17, 2018
Merged

feat(clearRefinements): implement InstantSearch.css #3114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ccd4b6c
docs(migration): clearRefinements migration
Sep 12, 2018
ae5fca9
refactor: clearAll -> clearRefinements
Sep 12, 2018
66901cf
fix(clearRefinements): excludeAttributes -> excludedAttributes
Sep 12, 2018
83c2a65
feat(ClearRefinements): update markup for is.css
Sep 12, 2018
1156aad
feat(clearRefinements): new options
Sep 13, 2018
ea0192d
docs(clearRefinements): provide initial refinements in dev-novel
Sep 13, 2018
2724bd4
Merge branch 'feat/3.0' into feat/3.0-clear-refinements
Sep 13, 2018
17c4fbb
test: consistent testing with description
Sep 13, 2018
7ccd41f
chore: ClearRefinements all the things
Sep 13, 2018
0a843c5
fix: replace black / white lists with better names
Sep 17, 2018
d8c20d4
chore: cleanup autoHideContainer related options
Sep 17, 2018
3799eb3
doc: wording for getRefinements and clearRefinemetns jsDoc
Sep 17, 2018
a263f67
Merge branch 'feat/3.0' into feat/3.0-clear-refinements
Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: cleanup autoHideContainer related options
  • Loading branch information
Alex S committed Sep 17, 2018
commit d8c20d42c07fd632a7ea44186e0c066810e934a1
3 changes: 0 additions & 3 deletions dev/app/builtin/stories/clear-refinements.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export default () => {
window.search.addWidget(
instantsearch.widgets.clearRefinements({
container,
autoHideContainer: false,
})
);
},
Expand All @@ -33,7 +32,6 @@ export default () => {
window.search.addWidget(
instantsearch.widgets.clearRefinements({
container,
autoHideContainer: false,
})
);
})
Expand All @@ -45,7 +43,6 @@ export default () => {
window.search.addWidget(
instantsearch.widgets.clearRefinements({
container,
autoHideContainer: false,
clearsQuery: true,
templates: {
link: 'Clear refinements and query',
Expand Down
4 changes: 0 additions & 4 deletions src/widgets/clear-refinements/__tests__/__snapshots__/clear-refinements-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ exports[`clearRefinements() with refinements calls twice ReactDOM.render(<ClearA
}
hasRefinements={true}
refine={[Function]}
shouldAutoHideContainer={false}
templateProps={
Object {
"templates": Object {
Expand Down Expand Up @@ -40,7 +39,6 @@ exports[`clearRefinements() with refinements calls twice ReactDOM.render(<ClearA
}
hasRefinements={true}
refine={[Function]}
shouldAutoHideContainer={false}
templateProps={
Object {
"templates": Object {
Expand Down Expand Up @@ -68,7 +66,6 @@ exports[`clearRefinements() without refinements calls twice ReactDOM.render(<Cle
}
hasRefinements={false}
refine={[Function]}
shouldAutoHideContainer={true}
templateProps={
Object {
"templates": Object {
Expand Down Expand Up @@ -96,7 +93,6 @@ exports[`clearRefinements() without refinements calls twice ReactDOM.render(<Cle
}
hasRefinements={false}
refine={[Function]}
shouldAutoHideContainer={true}
templateProps={
Object {
"templates": Object {
Expand Down
7 changes: 0 additions & 7 deletions src/widgets/clear-refinements/clear-refinements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const renderer = ({
containerNode,
cssClasses,
collapsible,
autoHideContainer,
renderState,
templates,
}) => ({ refine, hasRefinements, instantSearchInstance }, isFirstRendering) => {
Expand All @@ -29,15 +28,12 @@ const renderer = ({
return;
}

const shouldAutoHideContainer = autoHideContainer && !hasRefinements;

render(
<ClearRefinements
refine={refine}
collapsible={collapsible}
cssClasses={cssClasses}
hasRefinements={hasRefinements}
shouldAutoHideContainer={shouldAutoHideContainer}
templateProps={renderState.templateProps}
/>,
containerNode
Expand All @@ -49,7 +45,6 @@ clearRefinements({
container,
[ cssClasses.{root,button,disabledButton}={} ],
[ templates.{resetLabel}={resetLabel: 'Clear all refinements'} ],
[ autoHideContainer=true ],
[ collapsible=false ],
[ excludedAttributes=[] ]
})`;
Expand Down Expand Up @@ -100,7 +95,6 @@ export default function clearRefinements({
templates = defaultTemplates,
cssClasses: userCssClasses = {},
collapsible = false,
autoHideContainer = true,
excludedAttributes = [],
clearsQuery = false,
}) {
Expand All @@ -123,7 +117,6 @@ export default function clearRefinements({
containerNode,
cssClasses,
collapsible,
autoHideContainer,
renderState: {},
templates,
});
Expand Down