feat(numeric-selector): implement InstantSearch.css #3130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Deploy preview for algolia-instantsearch ready! Built with commit 35edaff https://deploy-preview-3130--algolia-instantsearch.netlify.com |
francoischalifour
changed the title
Contributor
|
Alternative stories are broken. |
Contributor
Author
|
They were already because we don't accept I'll fix that in this PR. |
bobylito
reviewed
Sep 21, 2018
Contributor
bobylito
left a comment
bobylito
left a comment
There was a problem hiding this comment.
Looks good but the stories don't seem to all work.
francoischalifour
force-pushed
the
feat/3.0-numeric-selector
branch
from
c1bcdbc to
acf39c0
Compare
francoischalifour
force-pushed
the
feat/3.0-numeric-selector
branch
from
acf39c0 to
857b1ff
Compare
Contributor
Author
Haroenv
requested changes
Oct 3, 2018
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
in the storybook the "with default selected" doesn't work
samouss
reviewed
Oct 3, 2018
Contributor
samouss
left a comment
samouss
left a comment
There was a problem hiding this comment.
We didn't implemented it in Vue, React and it's not documented on Angular. We can close the PR but keep it until we are sure to remove it.
Contributor
Author
Contributor
Author
|
Closing in favor of #3183. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs
https://instantsearch-css.netlify.com/widgets/numeric-selector/
Stories
https://deploy-preview-3130--algolia-instantsearch.netlify.com/v2/dev-novel/?selectedStory=NumericSelector.default