Skip to content

feat(numericSelector): remove widget #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoischalifour merged 2 commits into from
Oct 10, 2018
Merged

feat(numericSelector): remove widget #3183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b4711
feat(numericSelector): remove widget
francoischalifour Oct 8, 2018
d38b274
docs(migration): remove widget
francoischalifour Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dev/app/builtin/init-stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import initInstantSearchStories from './stories/instantsearch.stories';
import initMenuStories from './stories/menu.stories';
import initMenuSelectStories from './stories/menu-select.stories';
import initNumericRefinementListStories from './stories/numeric-refinement-list.stories';
import initNumericSelectorStories from './stories/numeric-selector.stories';
import initPaginationStories from './stories/pagination.stories';
import initRangeInputStories from './stories/range-input.stories.js';
import initRangeSliderStories from './stories/range-slider.stories';
Expand All @@ -38,7 +37,6 @@ export default () => {
initMenuStories();
initMenuSelectStories();
initNumericRefinementListStories();
initNumericSelectorStories();
initPaginationStories();
initRangeInputStories();
initRangeSliderStories();
Expand Down
73 changes: 0 additions & 73 deletions dev/app/builtin/stories/numeric-selector.stories.js
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions dev/app/init-unmount-widgets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,23 +206,6 @@ export default () => {
)
);

storiesOf('NumericSelector').add(
'default',
wrapWithUnmount(container =>
instantsearch.widgets.numericSelector({
container,
operator: '>=',
attributeName: 'popularity',
options: [
{ label: 'Default', value: 0 },
{ label: 'Top 10', value: 9991 },
{ label: 'Top 100', value: 9901 },
{ label: 'Top 500', value: 9501 },
],
})
)
);

storiesOf('Pagination').add(
'default',
wrapWithUnmount(container =>
Expand Down
2 changes: 0 additions & 2 deletions dev/app/jquery/init-stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import initHitsPerPageStories from './stories/hits-per-page.stories';
import initInfiniteHitsStories from './stories/infinite-hits.stories';
import initMenuStories from './stories/menu.stories';
import initNumericRefinementListStories from './stories/numeric-refinement-list.stories';
import initNumericSelectorStories from './stories/numeric-selector.stories';
import initPaginationStories from './stories/pagination.stories';
import initRefinementListStories from './stories/refinement-list.stories';
import initSearchBoxStories from './stories/search-box.stories';
Expand All @@ -25,7 +24,6 @@ export default () => {
initInfiniteHitsStories();
initMenuStories();
initNumericRefinementListStories();
initNumericSelectorStories();
initPaginationStories();
initRefinementListStories();
initSearchBoxStories();
Expand Down
26 changes: 0 additions & 26 deletions dev/app/jquery/stories/numeric-selector.stories.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dev/app/jquery/widgets/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export { default as pagination } from './pagination';
export { default as hitsPerPage } from './hitsPerPage';
export { default as hits } from './hits';
export { default as refinementList } from './refinementList';
export { default as numericSelector } from './numericSelector';
export { default as numericRefinementList } from './numericRefinementList';
export { default as searchBox } from './searchBox';
export { default as sortBy } from './sortBy';
Expand Down
34 changes: 0 additions & 34 deletions dev/app/jquery/widgets/numericSelector.js
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions docgen/src/examples/tourism/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,21 +88,5 @@ window.addEventListener('load', function() {
})
);

search.addWidget(
instantsearch.widgets.numericSelector({
container: '#guests',
attributeName: 'person_capacity',
operator: '>=',
options: [
{ label: '1 guest', value: 1},
{ label: '2 guests', value: 2},
{ label: '3 guests', value: 3},
{ label: '4 guests', value: 4},
{ label: '5 guests', value: 5},
{ label: '6 guests', value: 6}
]
})
);

search.start();
});
3 changes: 0 additions & 3 deletions docgen/src/guides/routing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,6 @@ But the `uiState` object is created by InstantSearch.js internally and thus part
numericRefinementList: {
heightInCm: 40
},
numericSelector: {
widthInCm: 30
},
range: {
ageInYears: '2-10'
},
Expand Down
4 changes: 4 additions & 0 deletions docgen/src/guides/v3-migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,10 @@ With the redo button:
</div>
```

### NumericSelector

Widget removed.
Copy link
Contributor

@Haroenv Haroenv Oct 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should say "replaced by numericMenu" or something like that

Copy link
Contributor Author

@francoischalifour francoischalifour Oct 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not replaced but rather can be reproduced with NumericMenu. Let's write a guide later on?

Copy link
Contributor

@Haroenv Haroenv Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me, but should at least link to it IMO

Copy link
Contributor Author

@francoischalifour francoischalifour Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - will do another PR to review the whole migration guide. Let's move forward with this PR.


### Pagination

#### Options
Expand Down
17 changes: 0 additions & 17 deletions functional-tests/app/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,21 +268,4 @@ search.once('render', function() {
document.querySelector('.search').className = 'row search search--visible';
});

search.addWidget(
instantsearch.widgets.numericSelector({
container: '#popularity-selector',
operator: '>=',
attributeName: 'popularity',
options: [
{ label: 'Default', value: 0 },
{ label: 'Top 10', value: 9991 },
{ label: 'Top 100', value: 9901 },
{ label: 'Top 500', value: 9501 },
],
cssClasses: {
select: 'form-control',
},
})
);

search.start();
3 changes: 0 additions & 3 deletions src/connectors/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ export { default as connectMenu } from './menu/connectMenu.js';
export {
default as connectNumericRefinementList,
} from './numeric-refinement-list/connectNumericRefinementList.js';
export {
default as connectNumericSelector,
} from './numeric-selector/connectNumericSelector.js';
export {
default as connectPagination,
} from './pagination/connectPagination.js';
Expand Down
Loading