Skip to content

fix(InfiniteHits): correctly set the class for last page #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoischalifour merged 1 commit into from
Oct 26, 2018
Merged

fix(InfiniteHits): correctly set the class for last page #3232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/components/InfiniteHits/InfiniteHits.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,15 @@ const InfiniteHits = ({
))}
</ol>

{isLastPage ? (
<button disabled className={cssClasses.loadMore}>
{loadMoreLabel}
</button>
) : (
<button
onClick={showMore}
className={cx(cssClasses.loadMore, cssClasses.disabledLoadMore)}
>
{loadMoreLabel}
</button>
)}
<button
className={cx(cssClasses.loadMore, {
[cssClasses.disabledLoadMore]: isLastPage,
})}
disabled={isLastPage}
onClick={showMore}
>
{loadMoreLabel}
</button>
</div>
);
};
Expand Down
5 changes: 3 additions & 2 deletions src/components/InfiniteHits/__tests__/__snapshots__/InfiniteHits-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ exports[`InfiniteHits markup should render <InfiniteHits /> on first page 1`] =
/>
</ol>
<button
className="loadMore disabledLoadMore"
className="loadMore"
disabled={false}
/>
</div>
`;
Expand Down Expand Up @@ -55,7 +56,7 @@ exports[`InfiniteHits markup should render <InfiniteHits /> on last page 1`] = `
/>
</ol>
<button
className="loadMore"
className="loadMore disabledLoadMore"
disabled={true}
/>
</div>
Expand Down