Skip to content

fix(range-input): fix button classname #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoischalifour merged 2 commits into from
Oct 26, 2018
Merged

fix(range-input): fix button classname #3234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9b708e
fix(range-input): fix button classname
francoischalifour Oct 26, 2018
ccc609f
docs(migration): fix button class name
francoischalifour Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docgen/src/guides/v3-migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ Widget removed.
| `ais-range-input--inputMin` | `ais-RangeInput-input--min` |
| `ais-range-input--inputMax` | `ais-RangeInput-input--max` |
| `ais-range-input--separator` | `ais-RangeInput-separator` |
| `ais-range-input--submit` | `ais-RangeInput-button` |
| `ais-range-input--submit` | `ais-RangeInput-submit` |

#### Markup

Expand Down
4 changes: 2 additions & 2 deletions src/components/RangeInput/RangeInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class RangeInput extends Component {

<button
type="submit"
className={cssClasses.button}
className={cssClasses.submit}
disabled={isDisabled}
>
{labels.submit}
Expand Down Expand Up @@ -105,7 +105,7 @@ RangeInput.propTypes = {
inputMin: PropTypes.string.isRequired,
inputMax: PropTypes.string.isRequired,
separator: PropTypes.string.isRequired,
button: PropTypes.string.isRequired,
submit: PropTypes.string.isRequired,
}).isRequired,
labels: PropTypes.shape({
separator: PropTypes.string.isRequired,
Expand Down
2 changes: 1 addition & 1 deletion src/components/RangeInput/__tests__/RangeInput-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe('RangeInput', () => {
inputMin: 'inputMin',
inputMax: 'inputMax',
separator: 'separator',
button: 'button',
submit: 'submit',
},
labels: {
separator: 'to',
Expand Down
18 changes: 9 additions & 9 deletions src/components/RangeInput/__tests__/__snapshots__/RangeInput-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ exports[`RangeInput expect to render 1`] = `
/>
</label>
<button
className="button"
className="submit"
disabled={false}
type="submit"
>
Expand Down Expand Up @@ -94,7 +94,7 @@ exports[`RangeInput expect to render with disabled state 1`] = `
/>
</label>
<button
className="button"
className="submit"
disabled={true}
type="submit"
>
Expand Down Expand Up @@ -148,7 +148,7 @@ exports[`RangeInput expect to render with values 1`] = `
/>
</label>
<button
className="button"
className="submit"
disabled={false}
type="submit"
>
Expand Down Expand Up @@ -201,7 +201,7 @@ exports[`RangeInput onChange expect to update the state when max change 1`] = `
/>
</label>
<button
className="button"
className="submit"
disabled={false}
type="submit"
>
Expand Down Expand Up @@ -254,7 +254,7 @@ exports[`RangeInput onChange expect to update the state when min change 1`] = `
/>
</label>
<button
className="button"
className="submit"
disabled={false}
type="submit"
>
Expand Down Expand Up @@ -306,7 +306,7 @@ exports[`RangeInput willReceiveProps expect to update the empty state from given
/>
</label>
<button
className="button"
className="submit"
disabled={false}
type="submit"
>
Expand Down Expand Up @@ -358,7 +358,7 @@ exports[`RangeInput willReceiveProps expect to update the empty state from given
/>
</label>
<button
className="button"
className="submit"
disabled={false}
type="submit"
>
Expand Down Expand Up @@ -412,7 +412,7 @@ exports[`RangeInput willReceiveProps expect to update the state from given props
/>
</label>
<button
className="button"
className="submit"
disabled={false}
type="submit"
>
Expand Down Expand Up @@ -466,7 +466,7 @@ exports[`RangeInput willReceiveProps expect to update the state from given props
/>
</label>
<button
className="button"
className="submit"
disabled={false}
type="submit"
>
Expand Down
12 changes: 6 additions & 6 deletions src/widgets/range-input/__tests__/__snapshots__/range-input-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ exports[`rangeInput expect to render with custom classNames 1`] = `
collapsible={false}
cssClasses={
Object {
"button": "ais-RangeInput-button",
"form": "ais-RangeInput-form custom-form",
"input": "ais-RangeInput-input",
"inputMax": "ais-RangeInput-input--max custom-inputMax",
Expand All @@ -14,6 +13,7 @@ exports[`rangeInput expect to render with custom classNames 1`] = `
"noRefinement": "ais-RangeInput--noRefinement",
"root": "ais-RangeInput custom-root",
"separator": "ais-RangeInput-separator custom-separator",
"submit": "ais-RangeInput-submit custom-submit",
}
}
labels={
Expand All @@ -40,7 +40,6 @@ exports[`rangeInput expect to render with custom labels 1`] = `
collapsible={false}
cssClasses={
Object {
"button": "ais-RangeInput-button",
"form": "ais-RangeInput-form",
"input": "ais-RangeInput-input",
"inputMax": "ais-RangeInput-input--max",
Expand All @@ -49,6 +48,7 @@ exports[`rangeInput expect to render with custom labels 1`] = `
"noRefinement": "ais-RangeInput--noRefinement",
"root": "ais-RangeInput",
"separator": "ais-RangeInput-separator",
"submit": "ais-RangeInput-submit",
}
}
labels={
Expand All @@ -75,7 +75,6 @@ exports[`rangeInput expect to render with refinement 1`] = `
collapsible={false}
cssClasses={
Object {
"button": "ais-RangeInput-button",
"form": "ais-RangeInput-form",
"input": "ais-RangeInput-input",
"inputMax": "ais-RangeInput-input--max",
Expand All @@ -84,6 +83,7 @@ exports[`rangeInput expect to render with refinement 1`] = `
"noRefinement": "ais-RangeInput--noRefinement",
"root": "ais-RangeInput",
"separator": "ais-RangeInput-separator",
"submit": "ais-RangeInput-submit",
}
}
labels={
Expand All @@ -110,7 +110,6 @@ exports[`rangeInput expect to render with refinement at boundaries 1`] = `
collapsible={false}
cssClasses={
Object {
"button": "ais-RangeInput-button",
"form": "ais-RangeInput-form",
"input": "ais-RangeInput-input",
"inputMax": "ais-RangeInput-input--max",
Expand All @@ -119,6 +118,7 @@ exports[`rangeInput expect to render with refinement at boundaries 1`] = `
"noRefinement": "ais-RangeInput--noRefinement",
"root": "ais-RangeInput",
"separator": "ais-RangeInput-separator",
"submit": "ais-RangeInput-submit",
}
}
labels={
Expand All @@ -145,7 +145,6 @@ exports[`rangeInput expect to render with results 1`] = `
collapsible={false}
cssClasses={
Object {
"button": "ais-RangeInput-button",
"form": "ais-RangeInput-form",
"input": "ais-RangeInput-input",
"inputMax": "ais-RangeInput-input--max",
Expand All @@ -154,6 +153,7 @@ exports[`rangeInput expect to render with results 1`] = `
"noRefinement": "ais-RangeInput--noRefinement",
"root": "ais-RangeInput",
"separator": "ais-RangeInput-separator",
"submit": "ais-RangeInput-submit",
}
}
labels={
Expand All @@ -180,7 +180,6 @@ exports[`rangeInput expect to render without results 1`] = `
collapsible={false}
cssClasses={
Object {
"button": "ais-RangeInput-button",
"form": "ais-RangeInput-form",
"input": "ais-RangeInput-input",
"inputMax": "ais-RangeInput-input--max",
Expand All @@ -189,6 +188,7 @@ exports[`rangeInput expect to render without results 1`] = `
"noRefinement": "ais-RangeInput--noRefinement",
"root": "ais-RangeInput",
"separator": "ais-RangeInput-separator",
"submit": "ais-RangeInput-submit",
}
}
labels={
Expand Down
2 changes: 1 addition & 1 deletion src/widgets/range-input/range-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export default function rangeInput({
suit({ descendantName: 'separator' }),
userCssClasses.separator
),
button: cx(suit({ descendantName: 'button' }), userCssClasses.button),
submit: cx(suit({ descendantName: 'submit' }), userCssClasses.submit),
};

const specializedRenderer = renderer({
Expand Down