-
Notifications
You must be signed in to change notification settings - Fork 557
chore: remove CSS source #3235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove CSS source #3235
Conversation
|
Deploy preview for algolia-instantsearch ready! Built with commit 233a6ab https://deploy-preview-3235--algolia-instantsearch.netlify.com |
Haroenv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docgen & dev novel should now use InstantSearch.css
|
@Haroenv Dev novel already uses InstantSearch.css: https://github.com/algolia/instantsearch.js/blob/chore/remove-css-source/dev/template.html#L16 Docgen needs InstantSearch styles only for the widget showcase, which relies on InstantSearch 2 for now. We need to publish InstantSearch 3 beta and add the styles there afterwards: https://github.com/algolia/instantsearch.js/blob/chore/remove-css-source/docgen/layouts/widget-showcase.pug#L6 |
|
hmm, indeed for a separate PR, but would be nice if it could come from source instead (although it barely matters since this docs site won't live for very long anymore) |
|
I'm not sure it's worth the trouble to be honest. |
samouss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we drop the doc from this repo we have to clean the package.json. There is some deps that are only use for docgen on the top level package. Don't think it worth the effort since we'll drop most of them with the doc move.
|
@samouss I tried removing as many top-level dependencies as possible but we actually use them for the We can still do another pass later. |
We don't use the CSS source of this project anymore but rely on InstantSearch.css.