Skip to content

Conversation

@francoischalifour
Copy link
Contributor

We don't use the CSS source of this project anymore but rely on InstantSearch.css.

@francoischalifour francoischalifour requested a review from a team October 26, 2018 11:18
@algobot
Copy link
Contributor

algobot commented Oct 26, 2018

Deploy preview for algolia-instantsearch ready!

Built with commit 233a6ab

https://deploy-preview-3235--algolia-instantsearch.netlify.com

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docgen & dev novel should now use InstantSearch.css

@francoischalifour
Copy link
Contributor Author

@Haroenv Dev novel already uses InstantSearch.css: https://github.com/algolia/instantsearch.js/blob/chore/remove-css-source/dev/template.html#L16

Docgen needs InstantSearch styles only for the widget showcase, which relies on InstantSearch 2 for now. We need to publish InstantSearch 3 beta and add the styles there afterwards: https://github.com/algolia/instantsearch.js/blob/chore/remove-css-source/docgen/layouts/widget-showcase.pug#L6

@Haroenv
Copy link
Contributor

Haroenv commented Oct 26, 2018

hmm, indeed for a separate PR, but would be nice if it could come from source instead (although it barely matters since this docs site won't live for very long anymore)

@francoischalifour
Copy link
Contributor Author

I'm not sure it's worth the trouble to be honest.

Copy link
Contributor

@samouss samouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we drop the doc from this repo we have to clean the package.json. There is some deps that are only use for docgen on the top level package. Don't think it worth the effort since we'll drop most of them with the doc move.

@francoischalifour
Copy link
Contributor Author

francoischalifour commented Oct 28, 2018

@samouss I tried removing as many top-level dependencies as possible but we actually use them for the dev/ folder and our stories.

We can still do another pass later.

@francoischalifour francoischalifour merged commit 7018390 into feat/3.0 Oct 28, 2018
@francoischalifour francoischalifour deleted the chore/remove-css-source branch October 28, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants