refactor(components): update components architecture #3248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves all components to their own folder for consistency.
Contributor
|
Deploy preview for algolia-instantsearch ready! Built with commit 13e271c https://deploy-preview-3248--algolia-instantsearch.netlify.com |
Haroenv
reviewed
Oct 30, 2018
| import React, { Component } from 'preact-compat'; | ||
| import isEqual from 'lodash/isEqual'; | ||
| import Template from '../Template.js'; | ||
| import Template from '../Template/Template'; |
Contributor
There was a problem hiding this comment.
now that you're moving files around anyway, do you know why we use the name twice, and not index.js?
Contributor
Author
There was a problem hiding this comment.
I'm not sure, it's a decision made before I started contributing. The goal of this PR is mainly to make it consistent for now.
I think a next step will be to remove folders like the React InstantSearch component architecture (but we'll take this decision a bit later).
samouss
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all components to their own folder for consistency.