feat(breadcrumb): implement Panel specs #3255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Deploy preview for instantsearchjs ready! Built with commit 7f3ad66 |
tkrugg
reviewed
Nov 15, 2018
| }; | ||
|
|
||
| this._refine = function(facetValue) { | ||
| renderingRefine = function(facetValue) { |
Contributor
There was a problem hiding this comment.
can be an arrow function.
I think it's best to use them when possible as they don't force you to think about context.
Contributor
Author
|
Closing because passing the full |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the panel specs (#3253) for the
breadcrumbwidget.Stories
https://deploy-preview-3255--instantsearchjs.netlify.com/v2/dev-novel/?selectedStory=Panel.with%20breadcrumb