feat(autocomplete): default escapeHTML to true #3335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `escapeHits` to `escapeHTML` - Default `escapeHTML` to true
Contributor
|
Deploy preview for instantsearchjs ready! Built with commit 7014d3c |
Contributor
|
is this also requiring the helper's usage, like in hits now? cc @samouss |
Contributor
Author
|
What do you mean? |
Contributor
Contributor
|
Nope we did not enforce the helper usage yet (even inside |
Contributor
Author
|
Right, I thought you were talking about the JavaScript Helper, @Haroenv. We may want to call them "formatting helpers" to avoid confusion. |
src/connectors/autocomplete/__tests__/connectAutocomplete-test.js
Outdated
Show resolved
Hide resolved
src/connectors/autocomplete/__tests__/connectAutocomplete-test.js
Outdated
Show resolved
Hide resolved
samouss
requested changes
Dec 13, 2018
Contributor
samouss
left a comment
samouss
left a comment
There was a problem hiding this comment.
The value is not true by default.
samouss
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
escapeHitstoescapeHTMLescapeHTMLto true