chore(examples): migrate Calendar Widget example #3351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Deploy preview for instantsearchjs ready! Built with commit 90b67d1 |
samouss
reviewed
Dec 14, 2018
Contributor
samouss
left a comment
samouss
left a comment
There was a problem hiding this comment.
You don't update the guides at the same time?
samouss
requested changes
Dec 14, 2018
Contributor
samouss
left a comment
samouss
left a comment
There was a problem hiding this comment.
We should migrate the hits with the highlight function.
Contributor
Author
|
@samouss Good point, I updated the guide. |
samouss
requested changes
Dec 17, 2018
Contributor
samouss
left a comment
samouss
left a comment
There was a problem hiding this comment.
Inside the guide we should use the highlight helper rather than the notation {{{ }}}.
samouss
approved these changes
Dec 18, 2018
francoischalifour
added a commit
that referenced
this pull request
Dec 19, 2018
Using the beta version for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the latest beta version for now (https://cdn.jsdelivr.net/npm/instantsearch.js@beta).
Demo: https://deploy-preview-3351--instantsearchjs.netlify.com/examples/calendar-widget/