fix(panel): bind widget methods from panel #3364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All widget's methods need to be bound to not lose the `this` context when called from the `panel` widget. We need to check the type of the widget's attributes before binding them because some are not methods. An example of a previously failing widget using `panel` is `ratingMenu`. Closes #3347.
Contributor
|
Deploy preview for instantsearchjs ready! Built with commit f402cd6 |
samouss
reviewed
Dec 18, 2018
samouss
requested changes
Dec 20, 2018
samouss
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All widget's methods need to be bound to not lose the
thiscontext when called from thepanelwidget.We need to check the type of the widget's attributes before binding them because some are not methods.
An example of a previously failing widget using
panelisratingMenu.Closes #3347.