Skip to content

fix(routing): support parsing URLs with up to 100 refinements #3935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yannickcr merged 1 commit into from
Jul 10, 2019
Merged

fix(routing): support parsing URLs with up to 100 refinements #3935

yannickcr merged 1 commit into from
Jul 10, 2019

Conversation

@yannickcr
Copy link
Contributor

@yannickcr yannickcr commented Jul 10, 2019

Description

Backport of #3671 for InstantSearch v2.

Original description:

An issue raised by a customer is that when selecting more than 20 values with the routing option activated, the data structure returned by the parseURL function changes.

qs by default converts arrays with more than 20 items to an object. We want to avoid this because the data structure manipulated can therefore vary.

Setting the limit to 100 seems a good number because the engine's default is 100. It can go up to 1000 but it is very unlikely to select more than 100 items in the UI.

Reference

@algobot
Copy link
Contributor

algobot commented Jul 10, 2019

Deploy preview for instantsearchjs ready!

Built with commit 6079fd4

https://deploy-preview-3935--instantsearchjs.netlify.com

Haroenv
Haroenv reviewed Jul 10, 2019
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really back port features on v2?

@francoischalifour
Copy link
Contributor

francoischalifour commented Jul 10, 2019

@Haroenv Since this is an easy fix and that this one was implemented already, I guess it's fine?

@yannickcr yannickcr merged commit d6476e2 into v2 Jul 10, 2019
@yannickcr yannickcr deleted the fix/routing-parsing-urls-100-v2 branch July 10, 2019 13:01
yannickcr added a commit that referenced this pull request Jul 10, 2019
@yannickcr
v2.10.5
12f4732 
<a name="2.10.5"></a>

* **routing:** enforce RoutingManager is the last widget ([#3149](#3149)) ([1e86b2e](1e86b2e)), closes [#3148](#3148)
* **routing:** support parsing URLs with up to 100 refinements ([#3935](#3935)) ([d6476e2](d6476e2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Haroenv Haroenv Haroenv approved these changes

+1 more reviewer

@francoischalifour francoischalifour francoischalifour approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yannickcr @algobot @francoischalifour @Haroenv