Add missing peer dependency from algoliasearch-helper #4950
Conversation
yacinehmito
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 849aa8a:
|
The dependency algoliasearch-helper declares algoliasearch as a peer dependency [1], but instantsearch.js does not declare it as a dependency not a peer dependency. This can cause undefined issues during peer dependency resolution, and triggers warnings when using yarn v2+. The commit adds algoliasearch as a peer dependency. [1] https://github.com/algolia/algoliasearch-helper-js/blob/develop/package.json#L103
|
With typescript in mind it should probably indeed be a peer dependency, even though it's technically optional still |
|
I guess we could add it now. |
|
With npm v7 it breaks their build if they don't have it installed @tkrugg, so adding is a breaking change |
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
I misunderstood in which cases this errors. As we have the peer dependency in the helper, this doesn't consist of a breaking change, but just a fix
|
Thank you 😄 |
3 participants
The dependency algoliasearch-helper declares algoliasearch as a peer dependency [1], but instantsearch.js does not declare it as a dependency nor a peer dependency.
This can cause undefined issues during peer dependency resolution, and triggers warnings when using yarn v2+.
The commit adds algoliasearch as a peer dependency.