fix(configure): ignore data attributes #6380
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 393c969:
|
|
Thank you @Haroenv ❤️ |
| export function Configure(props: ConfigureProps) { | ||
| useConfigure({ ...props }, { $$widgetType: 'ais.configure' }); | ||
| useConfigure( | ||
| Object.keys(props).reduce<ConfigureProps>((acc, key) => { |
There was a problem hiding this comment.
Worth leaving a comment here about Sentry being the cause of this issue for future readers?
|
Thank you, @Haroenv Do you know of any workaround in the meantime? |
|
@victordelva you can apply this patch in your code base using for example patch-package. For the moment it seems that sentry is more responsible for patching their code to avoid adding attributes everywhere. |
|
can be closed now that getsentry/sentry-javascript-bundler-plugins#617 is merged |
Summary
ignore data attributes in configure
Result
fixes getsentry/sentry-javascript#12720 (comment)
I'm not yet convinced this is the right approach for all cases (may cause a slowdown possibly, although we already were spreading the props). Alternatively this could be in
setQueryParameteror similar possibly, but would make that function more expensive.In the mean time, anyone using the sentry plugin can use this patch