fix(types): expose types field in exports #6838
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
requested review from
a team,
FabienMotte and
shaejaz
and removed request for
a team
1 task
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a838d25:
|
FabienMotte
approved these changes
Dec 10, 2025
shaejaz
approved these changes
Dec 10, 2025
Contributor
shaejaz
left a comment
shaejaz
left a comment
There was a problem hiding this comment.
Should we also use the exports format for instantsearch.js and algoliasearch-helper? Currently they use main but not sure if there's a limitation on them.
Contributor
Author
|
we can't add exports to packages that don't have them yet, that's a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds the types field to exports. All other packages already have it set.
Result
fixes #6836
This isn't a breaking change