Skip to content

Fix NPE in Tracer when context size exceeds the limit (#1184) #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sczyh30 merged 2 commits into from
Feb 21, 2020
+39 −13
Merged

Fix NPE in Tracer when context size exceeds the limit (#1184) #1293

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1a7ca0
Fix NPE in Tracer when context size exceeds the limit (#1184)
cdfive Feb 19, 2020
8bee6fc
Do context clean-up in test case
cdfive Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Do context clean-up in test case
  • Loading branch information
@cdfive
cdfive committed Feb 20, 2020
commit 8bee6fc7ec5caf6ef6d1854c3189c6434c85a7f6
15 changes: 15 additions & 0 deletions sentinel-core/src/test/java/com/alibaba/csp/sentinel/TracerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,29 @@
package com.alibaba.csp.sentinel;

import com.alibaba.csp.sentinel.context.ContextTestUtil;
import com.alibaba.csp.sentinel.context.ContextUtil;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;

/**
* @author Carpenter Lee
*/
public class TracerTest extends Tracer {

@Before
public void setUp() {
ContextTestUtil.cleanUpContext();
ContextTestUtil.resetContextMap();
}

@After
public void tearDown() {
ContextTestUtil.cleanUpContext();
ContextTestUtil.resetContextMap();
}

@Test
public void testTraceWhenContextSizeExceedsThreshold() {
int i = 0;
Expand Down