Fix the order problem of SentinelGatewayFilter and other bugs#937
Merged
Conversation
… adapter common module Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
============================================
+ Coverage 42.54% 42.55% +<.01%
- Complexity 1441 1442 +1
============================================
Files 310 310
Lines 8993 8998 +5
Branches 1222 1222
============================================
+ Hits 3826 3829 +3
- Misses 4698 4701 +3
+ Partials 469 468 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fix some problems in API gateway adapter common and SC Gateway adapter module.
Does this pull request fix one issue?
Fixes #764
Describe how you did it
GatewayParamParser.@Orderannotation in Spring Cloud Gateway, so here I addedOrderedsupport for Spring Cloud Gateway filter. By default the order isHIGHEST_PRECEDENCE. (Related to Question about the order of SentinelGatewayFilter in Spring Cloud Gateway #764, cc @fangjian0423)Describe how to verify it
Run the test cases and demo.
Special notes for reviews
NONE