Skip to content

Fix the order problem of SentinelGatewayFilter and other bugs#937

Merged
cdfive merged 2 commits into
masterfrom
enhancement/gateway-0722
Jul 25, 2019
Merged

Fix the order problem of SentinelGatewayFilter and other bugs#937
cdfive merged 2 commits into
masterfrom
enhancement/gateway-0722

Conversation

@sczyh30
Copy link
Copy Markdown
Member

@sczyh30 sczyh30 commented Jul 22, 2019

Describe what this PR does / why we need it

Fix some problems in API gateway adapter common and SC Gateway adapter module.

Does this pull request fix one issue?

Fixes #764

Describe how you did it

Describe how to verify it

Run the test cases and demo.

Special notes for reviews

NONE

sczyh30 added 2 commits July 22, 2019 22:44
… adapter common module

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added kind/enhancement Category issues or prs related to enhancement. area/integrations Issues or PRs related to integrations with open-source components labels Jul 22, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #937 into master will increase coverage by <.01%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #937      +/-   ##
============================================
+ Coverage     42.54%   42.55%   +<.01%     
- Complexity     1441     1442       +1     
============================================
  Files           310      310              
  Lines          8993     8998       +5     
  Branches       1222     1222              
============================================
+ Hits           3826     3829       +3     
- Misses         4698     4701       +3     
+ Partials        469      468       -1
Impacted Files Coverage Δ Complexity Δ
...apter/gateway/common/param/GatewayParamParser.java 74.66% <40%> (ø) 27 <0> (ø) ⬇️
...inel/adapter/gateway/sc/SentinelGatewayFilter.java 35.48% <83.33%> (+8.56%) 4 <2> (+1) ⬆️
...m/alibaba/csp/sentinel/log/DateFileLogHandler.java 54.54% <0%> (-3.04%) 6% <0%> (-1%)
...ava/com/alibaba/csp/sentinel/node/ClusterNode.java 100% <0%> (+4.76%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd20dd...0900ee5. Read the comment docs.

@sczyh30 sczyh30 requested a review from cdfive July 24, 2019 14:07
Copy link
Copy Markdown
Collaborator

@cdfive cdfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdfive cdfive merged commit 103fa30 into master Jul 25, 2019
@sczyh30 sczyh30 deleted the enhancement/gateway-0722 branch July 25, 2019 07:23
@cdfive cdfive added this to the 1.6.3 milestone Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/integrations Issues or PRs related to integrations with open-source components kind/enhancement Category issues or prs related to enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question about the order of SentinelGatewayFilter in Spring Cloud Gateway

3 participants