This repository was archived by the owner on May 11, 2020. It is now read-only.
fix(events): pass through updated model values #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behaviour is that event handlers will be passed the value of each argument as it was at the time the event handler was created, which is when the directive is linked. This means an event handler being passed args derived from the scope will not receive any updated values. This commit will alter the behaviour to send through any updated model values.
allenhwkim
added a commit
that referenced
this pull request
May 17, 2015
fix(events): pass through updated model values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour is that event handlers will be
passed the value of each argument as it was at the time
the event handler was created, which is when the
directive is linked. This means an event handler being
passed args derived from the scope will not receive
any updated values.
This commit will alter the behaviour to send through
any updated model values.