This repository was archived by the owner on May 11, 2020. It is now read-only.
Updates to Test Harness #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this doesn’t fix any tests but stops some incidental errors from running `gulp test` - Update initialisation of karma as per https://github.com/karma-runner/gulp-karma. Avoids a deprecation warning. - Remove initialisation of global google object in ng-map-pool-spec. I confess I don’t know what this is trying to achieve but it caused this error “TypeError: undefined is not a constructor (evaluating 'google.maps.__gjsload__’)”. And this triggered “Unhandled rejection Error” during PhantomJS shutdown.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this doesn’t fix any tests but stops some incidental errors from
running
gulp testUpdate initialisation of karma as per
https://github.com/karma-runner/gulp-karma. Avoids a deprecation
warning.
Remove initialisation of global google object in ng-map-pool-spec. I
confess I don’t know what this is trying to achieve but it caused this
error “TypeError: undefined is not a constructor (evaluating
'google.maps.gjsload’)”. And this triggered “Unhandled rejection
Error” during PhantomJS shutdown.