Skip to content

Conversation

@Rjected
Copy link
Collaborator

@Rjected Rjected commented Feb 26, 2025

Motivation

In Odyssey it would be nice to reuse the OpEvm type, but with the additional precompiles.

Solution

Add a constructor to the OpEvm

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this mirrors the eth impl

pending @klkvr

cc @leruaa

@klkvr
Copy link
Member

klkvr commented Feb 26, 2025

@Rjected should we add this generic in Evm impl as well? as we do with EthEvm

impl<DB, I, PRECOMPILE> Evm for EthEvm<DB, I, PRECOMPILE>
where
DB: Database,
I: Inspector<EthEvmContext<DB>>,
PRECOMPILE: PrecompileProvider<Context = EthEvmContext<DB>, Output = InterpreterResult>,
{

@Rjected
Copy link
Collaborator Author

Rjected commented Feb 26, 2025

@Rjected should we add this generic in Evm impl as well? as we do with EthEvm

impl<DB, I, PRECOMPILE> Evm for EthEvm<DB, I, PRECOMPILE>
where
DB: Database,
I: Inspector<EthEvmContext<DB>>,
PRECOMPILE: PrecompileProvider<Context = EthEvmContext<DB>, Output = InterpreterResult>,
{

whoops yeah we should

@Rjected
Copy link
Collaborator Author

Rjected commented Feb 26, 2025

the Evm impl depends on bluealloy/revm#2119

@klkvr klkvr merged commit debf585 into main Mar 4, 2025
27 checks passed
@klkvr klkvr deleted the dan/add-op-evm-constructor branch March 4, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants