Preserve testCaseId from on-disk schema as entity.TestResult#testId#3335
Closed
grootstebozewolf wants to merge 3 commits into
Closed
Preserve testCaseId from on-disk schema as entity.TestResult#testId#3335grootstebozewolf wants to merge 3 commits into
grootstebozewolf wants to merge 3 commits into
Conversation
The on-disk Allure 2 schema (defined in allure-java's io.qameta.allure.model.TestResult) carries testCaseId. Allure 3's reader maps the same field onto its identity slot. Allure 2's Allure2Plugin#convert never reads result.getTestCaseId(), so the value is silently dropped on import even though the entity has a testId field ready for it. Map testCaseId -> testId during conversion. No new API, no UI change; the field is now reachable to widgets and downstream plugins that expect stable test identity (history, retries, baseline comparison). Adds Allure2PluginTest#shouldPropagateTestCaseIdToTestId and fixture test-case-id.json. Test fails on main and passes with this change. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Member
|
there is no point of such change |
Contributor
Author
|
Closing per reviewer feedback: |
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The on-disk Allure 2 schema (defined in allure-java's
io.qameta.allure.model.TestResult) carriestestCaseId. Allure 3's reader maps the same field onto its identity slot. Allure 2'sAllure2Plugin#convertnever readsresult.getTestCaseId(), so the value is silently dropped on import even though the entity has atestIdfield ready for it.This PR maps
testCaseId→testIdduring conversion. No new API, no UI change; the field is now reachable to widgets and downstream plugins that expect stable test identity (history, retries, baseline comparison). Tightens v2/v3 parity at zero cost.Checklist