Skip to content

Conversation

PeterJCLaw
Copy link
Collaborator

This matches aiokafka's behaviour aside from how we handle running out of messages, where we exit the loop rather than blocking. This is imperfect, but may be as good as we can get.

Fixes #224.

This matches aiokafka's behaviour aside from how we handle running
out of messages, where we exit the loop rather than blocking. This
is imperfect, but may be as good as we can get.

Fixes alm0ra#224
@PeterJCLaw PeterJCLaw marked this pull request as ready for review September 6, 2025 16:03
Copy link

@AMelacini AMelacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at the code and exercising the tests (taking also a look at their coverage)
I believe the PR is suitable for to be merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing async iterator in FakeAIOKafkaConsumer
2 participants