Remove unnecessary GovSpeak processing from Whitehall #10326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only place it's used, so let's move it closer to the code. We're looking to simplify - and ultimately delete - the `GovspeakHelper`, so let's start off by reducing it to just its core set of methods.
Again, this was only being used (indirectly) by DetailedGuidance, in one place. This also meant that the default of only pulling out h2s was useless code, as we were always specifying the heading levels we want to retrieve. We can therefore remove that default arg, remove the associated test, and have confidence it still works because of the govspeak_header_hierarchy test from the previous commit.
This thing doesn't seem to exist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. See audit.
Trello: https://trello.com/c/Ohej7WfX/3837-plan-moving-govspeak-rendering-out-of-whitehall
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.