Send only the English version in world_location_names #10508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-english worldwide organisation pages, the link that should send the user to the world location news page is not working. For example, see Česká republika on this embassy page, that links to
/world/ceska-republika/news
, but it should be/world/czechia/news
.This is because in government-frontend we are using the country name from world_location_names, and content data returns the native country name for translated pages, and not the English version, which is the one we need.
Because
world_locations
doesn't return only the English version for location name, this issue is affecting links on Woldwide Organisation, News Articles, Case Studies and Speech pages.Trello card: https://trello.com/c/dXfX6R0o/3433-fix-the-broken-link-in-the-head-of-some-non-english-worldwide-organisation-pages-that-links-to-the-world-location-news-page
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.