Present edit immediately to user if only single image uploaded [WHIT-2718]
#10862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
changed the title
edit immediately to user if only single image uploaded
patrickpatrickpatrick
force-pushed
the
spike-img-upload
branch
from
1d59da2 to
8b8635b
Compare
patrickpatrickpatrick
changed the title
edit immediately to user if only single image uploadededit immediately to user if only single image uploaded [WHIT-2718]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
If a user has only uploaded one file (that requires a crop) then proceed immediately to the edit screen instead of returning the user to the index to wait for the files to load.
Why
Since only one image is uploaded, it makes sense to present to the user the edit screen of the image they've just uploaded. This also makes it possible to implement flows in which only one image is allowed to be uploaded (such as a lead images).
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.